add f16_epsilon and f128_epsilon diagnostic items #141874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
tgross35
approved these changes
Jun 2, 2025
|
These are only used in clippy, but it makes sense that we have them for these types too. Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
tgross35
changed the title
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 2, 2025
add f16_epsilon and f128_epsilon diagnostic items cc rust-lang#116909 r? `@tgross35`
bors
added a commit
that referenced
this pull request
Jun 2, 2025
Rollup of 6 pull requests Successful merges: - #140715 (Clarify &mut-methods' docs on sync::OnceLock) - #141309 (x86 (32/64): go back to passing SIMD vectors by-ptr) - #141677 (Async drop - type instead of async drop fn, fixes #140484) - #141733 (C-variadic functions must be unsafe) - #141858 (Fix typo in `StructuralPartialEq` docs) - #141874 (add f16_epsilon and f128_epsilon diagnostic items) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jun 2, 2025
Rollup of 5 pull requests Successful merges: - #141767 (ci: use free runner for aarch64-gnu-llvm-19-1 PR job) - #141858 (Fix typo in `StructuralPartialEq` docs) - #141865 (Optionally don't steal the THIR) - #141874 (add f16_epsilon and f128_epsilon diagnostic items) - #141904 (test-float-parse: apply `cfg(not(bootstrap))`) r? `@ghost` `@rustbot` modify labels: rollup
|
@usamoi are you also planning to do the clippy updates? If not, probably makes sense to open an issue there so these don't get lost |
yes |
jieyouxu
pushed a commit
to jieyouxu/rustc-dev-guide
that referenced
this pull request
Jun 3, 2025
Rollup of 5 pull requests Successful merges: - rust-lang/rust#141767 (ci: use free runner for aarch64-gnu-llvm-19-1 PR job) - rust-lang/rust#141858 (Fix typo in `StructuralPartialEq` docs) - rust-lang/rust#141865 (Optionally don't steal the THIR) - rust-lang/rust#141874 (add f16_epsilon and f128_epsilon diagnostic items) - rust-lang/rust#141904 (test-float-parse: apply `cfg(not(bootstrap))`) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Jun 4, 2025
add f16_epsilon and f128_epsilon diagnostic items cc rust-lang#116909 r? ``@tgross35``
github-merge-queue bot
pushed a commit
to rust-lang/rust-clippy
that referenced
this pull request
Aug 24, 2025
followup of rust-lang/rust#141874 cc rust-lang/rust#116909 changelog: check f16 and f128 in float_equality_without_abs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #116909
r? @tgross35